Skip to content
Snippets Groups Projects
Commit ce81f558 authored by nimrod's avatar nimrod
Browse files

Address Checkov warnings.

Mostly ignore things I'm not interested in but it did find somethings.
parent 5dbeb94b
Branches
No related tags found
No related merge requests found
Pipeline #2582 passed
...@@ -108,6 +108,10 @@ output "timeout" { ...@@ -108,6 +108,10 @@ output "timeout" {
} }
resource "aws_lambda_function" "function" { resource "aws_lambda_function" "function" {
# checkov:skip=CKV_AWS_50
# checkov:skip=CKV_AWS_116
# checkov:skip=CKV_AWS_117
# checkov:skip=CKV_AWS_173
count = length(local.functions) count = length(local.functions)
runtime = var.runtime runtime = var.runtime
function_name = local.function_names[count.index] function_name = local.function_names[count.index]
...@@ -120,6 +124,7 @@ resource "aws_lambda_function" "function" { ...@@ -120,6 +124,7 @@ resource "aws_lambda_function" "function" {
handler = "${local.functions[count.index]}.handler" handler = "${local.functions[count.index]}.handler"
description = "${local.module} ${local.functions[count.index]} check in ${local.env}." description = "${local.module} ${local.functions[count.index]} check in ${local.env}."
memory_size = var.memory_size memory_size = var.memory_size
reserved_concurrent_executions = -1
tags = local.common_tags tags = local.common_tags
timeout = var.timeout timeout = var.timeout
......
resource "aws_cloudwatch_log_group" "lambda" { resource "aws_cloudwatch_log_group" "lambda" {
# checkov:skip=CKV_AWS_158
count = length(local.function_names) count = length(local.function_names)
name = "/aws/lambda/${local.function_names[count.index]}" name = "/aws/lambda/${local.function_names[count.index]}"
retention_in_days = var.log_retention retention_in_days = var.log_retention
......
resource "aws_s3_bucket" "payloads" { resource "aws_s3_bucket" "payloads" {
# checkov:skip=CKV_AWS_18
# checkov:skip=CKV_AWS_19
# checkov:skip=CKV_AWS_144
# checkov:skip=CKV_AWS_145
bucket = local.Name bucket = local.Name
tags = local.common_tags tags = local.common_tags
acl = "private" acl = "private"
...@@ -9,11 +13,21 @@ resource "aws_s3_bucket" "payloads" { ...@@ -9,11 +13,21 @@ resource "aws_s3_bucket" "payloads" {
} }
} }
locals { locals {
payloads_bucket_arn = aws_s3_bucket.payloads.arn payloads_bucket_arn = aws_s3_bucket.payloads.arn
payloads_bucket_name = aws_s3_bucket.payloads.bucket payloads_bucket_name = aws_s3_bucket.payloads.bucket
} }
resource "aws_s3_bucket_public_access_block" "payloads" {
bucket = aws_s3_bucket.payloads.bucket
block_public_acls = true
block_public_policy = true
ignore_public_acls = true
restrict_public_buckets = true
}
output "payloads_bucket_arn" { output "payloads_bucket_arn" {
description = "ARN of the payloads S3 bucket." description = "ARN of the payloads S3 bucket."
value = local.payloads_bucket_arn value = local.payloads_bucket_arn
...@@ -25,6 +39,7 @@ output "payloads_bucket_name" { ...@@ -25,6 +39,7 @@ output "payloads_bucket_name" {
} }
resource "aws_s3_bucket_object" "payload" { resource "aws_s3_bucket_object" "payload" {
# checkov:skip=CKV_AWS_186
bucket = local.payloads_bucket_name bucket = local.payloads_bucket_name
key = "payload.zip" key = "payload.zip"
source = "payload.zip" source = "payload.zip"
......
...@@ -12,6 +12,10 @@ variable "twilio_from_number" { ...@@ -12,6 +12,10 @@ variable "twilio_from_number" {
} }
resource "aws_lambda_function" "sms_notify" { resource "aws_lambda_function" "sms_notify" {
# checkov:skip=CKV_AWS_50
# checkov:skip=CKV_AWS_116
# checkov:skip=CKV_AWS_117
# checkov:skip=CKV_AWS_173
runtime = var.runtime runtime = var.runtime
function_name = "${local.function_name_prefix}-sms-notify" function_name = "${local.function_name_prefix}-sms-notify"
role = local.lambda_role_arn role = local.lambda_role_arn
...@@ -23,6 +27,7 @@ resource "aws_lambda_function" "sms_notify" { ...@@ -23,6 +27,7 @@ resource "aws_lambda_function" "sms_notify" {
handler = "sms_notify.handler" handler = "sms_notify.handler"
description = "Send SMS message notification using Twilio." description = "Send SMS message notification using Twilio."
memory_size = var.memory_size memory_size = var.memory_size
reserved_concurrent_executions = -1
tags = local.common_tags tags = local.common_tags
timeout = var.timeout timeout = var.timeout
...@@ -103,6 +108,7 @@ resource "aws_sns_topic_subscription" "sms_notify" { ...@@ -103,6 +108,7 @@ resource "aws_sns_topic_subscription" "sms_notify" {
] ]
} }
resource "aws_cloudwatch_log_group" "sms_notify" { resource "aws_cloudwatch_log_group" "sms_notify" {
# checkov:skip=CKV_AWS_158
name = "/aws/lambda/${local.function_name_prefix}-sms-notify" name = "/aws/lambda/${local.function_name_prefix}-sms-notify"
retention_in_days = var.log_retention retention_in_days = var.log_retention
tags = local.common_tags tags = local.common_tags
......
resource "aws_sns_topic" "topic" { resource "aws_sns_topic" "topic" {
# checkov:skip=CKV_AWS_26
name = local.Name name = local.Name
tags = local.common_tags tags = local.common_tags
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment