Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
A
Am I live
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
shore
Am I live
Commits
74931700
Commit
74931700
authored
4 years ago
by
nimrod
Browse files
Options
Downloads
Patches
Plain Diff
Revisit pylint warnings.
parent
de9a39a1
No related branches found
No related tags found
No related merge requests found
Pipeline
#1323
passed
4 years ago
Stage: test
Stage: build
Stage: plan
Stage: apply
Changes
3
Pipelines
1
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
src/_dns.py
+19
-18
19 additions, 18 deletions
src/_dns.py
src/mta_sts.py
+0
-1
0 additions, 1 deletion
src/mta_sts.py
src/utils.py
+2
-3
2 additions, 3 deletions
src/utils.py
with
21 additions
and
22 deletions
src/_dns.py
+
19
−
18
View file @
74931700
# pylint: disable=import-error,invalid-name
import
dns.resolver
# pylint: disable=import-error
import
dns.resolver
import
utils
import
utils
...
@@ -11,7 +10,9 @@ def get_resolvers():
...
@@ -11,7 +10,9 @@ def get_resolvers():
"""
Return a list of resolvers for each nameserver in the DNS zone.
"""
"""
Return a list of resolvers for each nameserver in the DNS zone.
"""
default_resolver
=
dns
.
resolver
.
Resolver
()
default_resolver
=
dns
.
resolver
.
Resolver
()
resolvers
=
[]
resolvers
=
[]
for
ns
in
default_resolver
.
query
(
DOMAIN
,
"
NS
"
):
for
ns
in
default_resolver
.
query
(
# pylint: disable=invalid-name
DOMAIN
,
"
NS
"
):
for
address
in
default_resolver
.
query
(
ns
.
to_text
()):
for
address
in
default_resolver
.
query
(
ns
.
to_text
()):
resolver
=
dns
.
resolver
.
Resolver
(
configure
=
False
)
resolver
=
dns
.
resolver
.
Resolver
(
configure
=
False
)
resolver
.
nameservers
=
[
address
.
to_text
()]
resolver
.
nameservers
=
[
address
.
to_text
()]
...
@@ -25,9 +26,9 @@ RESOLVERS = get_resolvers()
...
@@ -25,9 +26,9 @@ RESOLVERS = get_resolvers()
def
cross_query
(
qname
,
rdtype
=
"
A
"
):
def
cross_query
(
qname
,
rdtype
=
"
A
"
):
"""
Return all of the answers from all nameservers.
"""
"""
Return all of the answers from all nameservers.
"""
answers
=
set
()
answers
=
set
()
for
r
in
RESOLVERS
:
for
r
esolver
in
RESOLVERS
:
for
a
in
r
.
query
(
qname
,
rdtype
):
for
a
ddress
in
resolve
r
.
query
(
qname
,
rdtype
):
answers
.
add
(
a
)
answers
.
add
(
a
ddress
)
return
answers
return
answers
...
@@ -39,9 +40,9 @@ def validate_soa():
...
@@ -39,9 +40,9 @@ def validate_soa():
return
[
False
,
"
SOA records don
'
t match.
"
]
return
[
False
,
"
SOA records don
'
t match.
"
]
try
:
try
:
r
=
soas
.
pop
()
r
ecord
=
soas
.
pop
()
r
.
mname
.
to_text
()
r
ecord
.
mname
.
to_text
()
except
Exception
as
e
:
# pylint: disable=broad-except
except
Exception
as
e
:
# pylint: disable=broad-except
,invalid-name
print
(
str
(
e
))
print
(
str
(
e
))
return
[
False
,
"
SOA record is invalid.
"
]
return
[
False
,
"
SOA record is invalid.
"
]
...
@@ -55,11 +56,11 @@ def validate_mx():
...
@@ -55,11 +56,11 @@ def validate_mx():
return
[
False
,
"
MX records don
'
t match.
"
]
return
[
False
,
"
MX records don
'
t match.
"
]
try
:
try
:
r
=
mxs
.
pop
()
r
ecord
=
mxs
.
pop
()
ips
=
cross_query
(
r
.
exchange
.
to_text
())
ips
=
cross_query
(
r
ecord
.
exchange
.
to_text
())
if
len
(
ips
)
>
1
:
if
len
(
ips
)
>
1
:
return
[
False
,
"
MX records don
'
t match.
"
]
return
[
False
,
"
MX records don
'
t match.
"
]
except
Exception
as
e
:
# pylint: disable=broad-except
except
Exception
as
e
:
# pylint: disable=broad-except
,invalid-name
print
(
str
(
e
))
print
(
str
(
e
))
return
[
False
,
"
MX record is invalid.
"
]
return
[
False
,
"
MX record is invalid.
"
]
...
@@ -68,12 +69,12 @@ def validate_mx():
...
@@ -68,12 +69,12 @@ def validate_mx():
def
validate_subdomains
():
def
validate_subdomains
():
"""
Validate important subdomains.
"""
"""
Validate important subdomains.
"""
for
d
in
SUBDOMAINS
:
for
d
omain
in
SUBDOMAINS
:
try
:
try
:
ips
=
cross_query
(
d
)
ips
=
cross_query
(
d
omain
)
if
len
(
ips
)
>
1
:
if
len
(
ips
)
>
1
:
return
[
True
,
f
"
Domain
{
d
}
records don
'
t match.
"
]
return
[
True
,
f
"
Domain
{
d
omain
}
records don
'
t match.
"
]
except
Exception
as
e
:
# pylint: disable=broad-except
except
Exception
as
e
:
# pylint: disable=broad-except
,invalid-name
print
(
str
(
e
))
print
(
str
(
e
))
return
[
False
,
"
Failed to validate domain {d}.
"
]
return
[
False
,
"
Failed to validate domain {d}.
"
]
return
[
True
,
"
Subdomains validated.
"
]
return
[
True
,
"
Subdomains validated.
"
]
...
@@ -81,8 +82,8 @@ def validate_subdomains():
...
@@ -81,8 +82,8 @@ def validate_subdomains():
def
handler
(
event
,
context
):
# pylint: disable=unused-argument
def
handler
(
event
,
context
):
# pylint: disable=unused-argument
"""
Lambda event handler.
"""
"""
Lambda event handler.
"""
for
c
in
[
validate_soa
,
validate_mx
,
validate_subdomains
]:
for
c
heck
in
[
validate_soa
,
validate_mx
,
validate_subdomains
]:
success
,
message
=
c
.
__call__
()
success
,
message
=
c
heck
.
__call__
()
print
(
message
)
print
(
message
)
if
not
success
:
if
not
success
:
utils
.
publish
(
message
)
utils
.
publish
(
message
)
...
...
This diff is collapsed.
Click to expand it.
src/mta_sts.py
+
0
−
1
View file @
74931700
# pylint: disable=invalid-name
from
utils
import
check_urls
from
utils
import
check_urls
...
...
This diff is collapsed.
Click to expand it.
src/utils.py
+
2
−
3
View file @
74931700
# pylint: disable=import-error
import
os
import
os
import
boto3
import
boto3
# pylint: disable=import-error
import
requests
import
requests
# pylint: disable=import-error
TOPIC_ARN
=
os
.
getenv
(
"
TOPIC_ARN
"
)
TOPIC_ARN
=
os
.
getenv
(
"
TOPIC_ARN
"
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment