Skip to content
Snippets Groups Projects
Commit 74931700 authored by nimrod's avatar nimrod
Browse files

Revisit pylint warnings.

parent de9a39a1
No related branches found
No related tags found
No related merge requests found
Pipeline #1323 passed
# pylint: disable=import-error,invalid-name import dns.resolver # pylint: disable=import-error
import dns.resolver
import utils import utils
...@@ -11,7 +10,9 @@ def get_resolvers(): ...@@ -11,7 +10,9 @@ def get_resolvers():
"""Return a list of resolvers for each nameserver in the DNS zone.""" """Return a list of resolvers for each nameserver in the DNS zone."""
default_resolver = dns.resolver.Resolver() default_resolver = dns.resolver.Resolver()
resolvers = [] resolvers = []
for ns in default_resolver.query(DOMAIN, "NS"): for ns in default_resolver.query( # pylint: disable=invalid-name
DOMAIN, "NS"
):
for address in default_resolver.query(ns.to_text()): for address in default_resolver.query(ns.to_text()):
resolver = dns.resolver.Resolver(configure=False) resolver = dns.resolver.Resolver(configure=False)
resolver.nameservers = [address.to_text()] resolver.nameservers = [address.to_text()]
...@@ -25,9 +26,9 @@ RESOLVERS = get_resolvers() ...@@ -25,9 +26,9 @@ RESOLVERS = get_resolvers()
def cross_query(qname, rdtype="A"): def cross_query(qname, rdtype="A"):
"""Return all of the answers from all nameservers.""" """Return all of the answers from all nameservers."""
answers = set() answers = set()
for r in RESOLVERS: for resolver in RESOLVERS:
for a in r.query(qname, rdtype): for address in resolver.query(qname, rdtype):
answers.add(a) answers.add(address)
return answers return answers
...@@ -39,9 +40,9 @@ def validate_soa(): ...@@ -39,9 +40,9 @@ def validate_soa():
return [False, "SOA records don't match."] return [False, "SOA records don't match."]
try: try:
r = soas.pop() record = soas.pop()
r.mname.to_text() record.mname.to_text()
except Exception as e: # pylint: disable=broad-except except Exception as e: # pylint: disable=broad-except,invalid-name
print(str(e)) print(str(e))
return [False, "SOA record is invalid."] return [False, "SOA record is invalid."]
...@@ -55,11 +56,11 @@ def validate_mx(): ...@@ -55,11 +56,11 @@ def validate_mx():
return [False, "MX records don't match."] return [False, "MX records don't match."]
try: try:
r = mxs.pop() record = mxs.pop()
ips = cross_query(r.exchange.to_text()) ips = cross_query(record.exchange.to_text())
if len(ips) > 1: if len(ips) > 1:
return [False, "MX records don't match."] return [False, "MX records don't match."]
except Exception as e: # pylint: disable=broad-except except Exception as e: # pylint: disable=broad-except,invalid-name
print(str(e)) print(str(e))
return [False, "MX record is invalid."] return [False, "MX record is invalid."]
...@@ -68,12 +69,12 @@ def validate_mx(): ...@@ -68,12 +69,12 @@ def validate_mx():
def validate_subdomains(): def validate_subdomains():
"""Validate important subdomains.""" """Validate important subdomains."""
for d in SUBDOMAINS: for domain in SUBDOMAINS:
try: try:
ips = cross_query(d) ips = cross_query(domain)
if len(ips) > 1: if len(ips) > 1:
return [True, f"Domain {d} records don't match."] return [True, f"Domain {domain} records don't match."]
except Exception as e: # pylint: disable=broad-except except Exception as e: # pylint: disable=broad-except,invalid-name
print(str(e)) print(str(e))
return [False, "Failed to validate domain {d}."] return [False, "Failed to validate domain {d}."]
return [True, "Subdomains validated."] return [True, "Subdomains validated."]
...@@ -81,8 +82,8 @@ def validate_subdomains(): ...@@ -81,8 +82,8 @@ def validate_subdomains():
def handler(event, context): # pylint: disable=unused-argument def handler(event, context): # pylint: disable=unused-argument
"""Lambda event handler.""" """Lambda event handler."""
for c in [validate_soa, validate_mx, validate_subdomains]: for check in [validate_soa, validate_mx, validate_subdomains]:
success, message = c.__call__() success, message = check.__call__()
print(message) print(message)
if not success: if not success:
utils.publish(message) utils.publish(message)
......
# pylint: disable=invalid-name
from utils import check_urls from utils import check_urls
......
# pylint: disable=import-error
import os import os
import boto3 import boto3 # pylint: disable=import-error
import requests import requests # pylint: disable=import-error
TOPIC_ARN = os.getenv("TOPIC_ARN") TOPIC_ARN = os.getenv("TOPIC_ARN")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment