Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
boilr
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
nimrod
boilr
Commits
b605b84d
Commit
b605b84d
authored
8 years ago
by
Tamer Tas
Browse files
Options
Downloads
Patches
Plain Diff
pkg/host: refactor zipURL calculation
parent
2aea094a
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
pkg/host/github.go
+4
-4
4 additions, 4 deletions
pkg/host/github.go
with
4 additions
and
4 deletions
pkg/host/github.go
+
4
−
4
View file @
b605b84d
...
...
@@ -13,14 +13,14 @@ func ZipURL(repo string) string {
repo
=
strings
.
TrimSuffix
(
strings
.
TrimPrefix
(
repo
,
"/"
),
"/"
)
zipRegex
,
_
:=
regexp
.
Compile
(
`zip/(\S+)$`
)
zipRegex
:=
regexp
.
Must
Compile
(
`zip/(\S+)$`
)
if
zipRegex
.
MatchString
(
repo
)
{
return
repo
}
//
So this could
identify a port number, but since
we only support github
// I don't believe using it as a version modifier
is a problem. Though
//
p
erhaps we should
use something else instead
?
//
FIXME(tmrts): this check could also
identify a port number, but since
//
we only support github
I don't believe using it as a version modifier
//
is a problem. P
erhaps we should
reconsider
?
if
strings
.
Contains
(
repo
,
":"
)
{
parts
:=
strings
.
SplitAfter
(
repo
,
":"
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment