Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
boilr
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
nimrod
boilr
Commits
7eebc19a
Commit
7eebc19a
authored
8 years ago
by
Tamer Tas
Browse files
Options
Downloads
Patches
Plain Diff
Ensure URL calculation is portable (i.e. windows path separator bug)
Fixes #36
parent
0b64b1c1
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
pkg/host/github.go
+13
-10
13 additions, 10 deletions
pkg/host/github.go
with
13 additions
and
10 deletions
pkg/host/github.go
+
13
−
10
View file @
7eebc19a
package
host
package
host
import
(
import
(
"path/filepath"
"regexp"
"regexp"
"strings"
"strings"
)
)
const
githubStorageURL
=
"https://codeload.github.com"
// ZipURL returns the URL of the zip archive given a github repository URL.
// ZipURL returns the URL of the zip archive given a github repository URL.
func
ZipURL
(
url
string
)
string
{
func
ZipURL
(
repo
string
)
string
{
var
version
=
"master"
var
version
=
"master"
url
=
strings
.
TrimSuffix
(
strings
.
TrimPrefix
(
url
,
"/"
),
"/"
)
repo
=
strings
.
TrimSuffix
(
strings
.
TrimPrefix
(
repo
,
"/"
),
"/"
)
zipRegex
,
_
:=
regexp
.
Compile
(
`zip/(\S+)$`
)
zipRegex
,
_
:=
regexp
.
Compile
(
`zip/(\S+)$`
)
if
zipRegex
.
MatchString
(
url
)
{
if
zipRegex
.
MatchString
(
repo
)
{
return
url
return
repo
}
}
// So this could identify a port number, but since we only support github
// So this could identify a port number, but since we only support github
// I don't believe using it as a version modifier is a problem. Though
// I don't believe using it as a version modifier is a problem. Though
// perhaps we should use something else instead?
// perhaps we should use something else instead?
if
strings
.
Contains
(
url
,
":"
)
{
if
strings
.
Contains
(
repo
,
":"
)
{
parts
:=
strings
.
SplitAfter
(
url
,
":"
)
parts
:=
strings
.
SplitAfter
(
repo
,
":"
)
url
=
parts
[
0
]
repo
=
parts
[
0
]
version
=
parts
[
1
]
version
=
parts
[
1
]
url
=
strings
.
TrimSuffix
(
url
,
":"
)
repo
=
strings
.
TrimSuffix
(
repo
,
":"
)
}
}
return
"https://codeload.github.com/"
+
filepath
.
Join
(
url
,
"/zip/"
+
version
)
urlTokens
:=
[]
string
{
githubStorageURL
,
repo
,
"zip"
,
version
}
return
strings
.
Join
(
urlTokens
,
"/"
)
}
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment