pre-commit.

Use common Ansible snippet. Address issues.

.pre-commit-config.yaml

+---
 repos:
--   repo: https://github.com/pre-commit/pre-commit-hooks
-    sha: v1.1.1
+  - repo: https://github.com/pre-commit/pre-commit-hooks.git
+    rev: v3.4.0
     hooks:
       - id: check-added-large-files
-    -   id: check-yaml
+      - id: check-executables-have-shebangs
       - id: check-merge-conflict
       - id: check-symlinks
--   repo: https://www.shore.co.il/git/ansible-pre-commit
-    sha: v0.7.0
+      - id: trailing-whitespace
+
+  - repo: https://github.com/Yelp/detect-secrets
+    rev: v0.14.3
+    hooks:
+      - id: detect-secrets
+
+  - repo: https://github.com/adrienverge/yamllint
+    rev: v1.25.0
+    hooks:
+      - id: yamllint
+
+  - repo: https://github.com/amperser/proselint/
+    rev: 0.10.2
+    hooks:
+      - id: proselint
+        types: [plain-text]
+        exclude: LICENSE
+
+  - repo: https://github.com/executablebooks/mdformat.git
+    rev: 0.5.3
+    hooks:
+      - id: mdformat
+
+  - repo: https://git.shore.co.il/nimrod/shell-pre-commit.git
+    rev: v0.6.0
+    hooks:
+      - id: shell-lint
+
+  - repo: https://github.com/shellcheck-py/shellcheck-py.git
+    rev: v0.7.1.1
+    hooks:
+      - id: shellcheck
+
+  - repo: https://git.shore.co.il/ansible/ansible-pre-commit.git
+    rev: v0.10.0
     hooks:
       - id: ansible-syntax-check
-        files: &playbooks 'desktop.yml|dropbox\.yml|pkgs\.yml|skype\.yml|workstation\.yml|vscode\.yml'
--   repo: https://github.com/willthames/ansible-lint
-    sha: v3.4.16
+        files: &playbooks |-
+          'desktop.yml|dropbox\.yml|pkgs\.yml|skype\.yml|workstation\.yml|vscode\.yml'
+
+  - repo: https://github.com/ansible/ansible-lint
+    rev: v4.3.7
     hooks:
       - id: ansible-lint
         files: *playbooks

desktop.yml

 ---
 - hosts: all
-  become: yes
+  become: true
   become_user: root
   handlers:
     - name: Update initramfs
@@ -27,7 +27,7 @@
       apt_repository:
         repo: '{{ item }} http://download.videolan.org/pub/debian/stable/ /'
         state: present
-        update_cache: yes
+        update_cache: true
 
     - name: Add the Debian experimental suite repository
       with_items:
@@ -36,7 +36,7 @@
       apt_repository:
         repo: '{{ item }} http://httpredir.debian.org/debian experimental main'
         state: present
-        update_cache: yes
+        update_cache: true
 
     - name: Prioritize browsers from the Debian experimental suite
       template:
@@ -54,7 +54,7 @@
       apt:
         name: '{{ item }}'
         state: present
-      update_cache: yes
+        update_cache: true
         cache_valid_time: 3600
     - name: Configure Plymouth
       ini_file:
@@ -67,7 +67,13 @@
     - name: Configure GRUB
       with_dict:
         GRUB_TIMEOUT: 1
-      GRUB_CMDLINE_LINUX_DEFAULT: 'quiet cgroup_enable=memory splash allow-discards root_trim=yes swapaccount=1'
+        GRUB_CMDLINE_LINUX_DEFAULT: >-
+          quiet
+          cgroup_enable=memory
+          splash
+          allow-discards
+          root_trim=yes
+          swapaccount=1
       lineinfile:
         dest: /etc/default/grub
         line: '{{ item.key }}="{{ item.value }}"'

dropbox.yml

 ---
 - hosts: all
-  become: no
+  become: false
   tasks:
     - name: Assertions
       assert:
@@ -16,7 +16,7 @@
 
     - name: Unpack Dropbox tarball
       unarchive:
-            copy: no
+        copy: false
         dest: '{{ ansible_user_dir }}/'
         src: '{{ ansible_user_dir }}/Downloads/dropbox-lnx.x86_64.tar.gz'
         creates: '{{ ansible_user_dir }}/.dropbox-dist/dropboxd'

pkgs.yml

@@ -2,7 +2,8 @@
 - hosts: all
   become: false
   vars:
-      gopath: '{{ ansible_user_dir }}/Documents/Golang'
+    gopath: |-
+      {{ ansible_user_dir }}/Documents/Golang
     apt:
       - adb
       - apache2-utils
@@ -198,14 +199,14 @@
 
     - name: apt install
       when: apt is iterable
-        become: yes
+      become: true
       become_user: root
       apt:
         name: '{{ apt }}'
         state: present
-            purge: yes
-            force: yes
-            update_cache: yes
+        purge: true
+        force: true
+        update_cache: true
         cache_valid_time: 3600
 
     - name: Create the GOPATH directory
@@ -224,18 +225,18 @@
     - name: gem install
       with_items: '{{ gem }}'
       when: gem is iterable
-        become: yes
+      become: true
       become_user: root
       gem:
         name: '{{ item }}'
         state: present
-            include_dependencies: yes
+        include_dependencies: true
 
     - name: Update npm
-        become: yes
+      become: true
       become_user: root
       npm:
-            global: yes
+        global: true
         name: npm
         state: present
         version: '>=5'
@@ -243,16 +244,16 @@
     - name: npm install
       with_items: '{{ npm }}'
       when: npm is iterable
-        become: yes
+      become: true
       become_user: root
       npm:
-            global: yes
+        global: true
         name: '{{ item }}'
         state: present
 
     - name: pip2 install
       when: pip2 is iterable
-        become: yes
+      become: true
       become_user: root
       pip:
         name: '{{ pip2 }}'
@@ -261,7 +262,7 @@
 
     - name: pip3 install
       when: pip3 is iterable
-        become: yes
+      become: true
       become_user: root
       pip:
         name: '{{ pip3 }}'
@@ -270,8 +271,10 @@
 
     - name: cargo install
       when: cargo is iterable
-        become: no
+      become: false
       command: '/usr/bin/cargo install {{ cargo|join(" ") }}'
       register: cargo_install
-        failed_when: cargo_install.rc > 0 and not 'already exists in destination' in cargo_install.stderr
+      failed_when: >-
+        cargo_install.rc > 0 and
+        not 'already exists in destination' in cargo_install.stderr
       changed_when: cargo_install.rc == 0

skype.yml

@@ -13,20 +13,22 @@
       apt:
         name: flatpak
         state: present
-            update_cache: yes
+        update_cache: true
         cache_valid_time: 3600
 
     - name: Add Flathub repo
-        become: False
-        command: |
-            flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo --user
-        changed_when: False
+      become: false
+      # yamllint disable-line rule:line-length
+      command: flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo --user
+      changed_when: false
 
     - name: Install
-        become: False
-        command: |
-            flatpak install --user --assumeyes flathub com.skype.Client
+      become: false
+      # yamllint disable-line rule:line-length
+      command: flatpak install --user --assumeyes flathub com.skype.Client
       register: skype_flatpak_install
-        changed_when: |
+      changed_when: |-
         'Installing' in skype_flatpak_install.stdout
-        failed_when: skype_flatpak_install.rc|int > 0 and 'already installed' not in skype_flatpak_install.stderr
+      failed_when: >-
+        skype_flatpak_install.rc|int > 0 and
+        'already installed' not in skype_flatpak_install.stderr

slack.yml

 ---
 - hosts: all
-  become: yes
+  become: true
   become_user: root
   tasks:
     - name: Assertions
@@ -13,20 +13,22 @@
       apt:
         name: flatpak
         state: present
-            update_cache: yes
+        update_cache: true
         cache_valid_time: 3600
 
     - name: Add Flathub repo
-        become: False
-        command: |
-            flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo --user
-        changed_when: False
+      become: false
+      # yamllint disable-line rule:line-length
+      command: flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo --user
+      changed_when: false
 
     - name: Install
-        become: False
-        command: |
-            flatpak install --user --assumeyes flathub com.slack.Slack
+      become: false
+      # yamllint disable-line rule:line-length
+      command: flatpak install --user --assumeyes flathub com.slack.Slack
       register: slack_flatpak_install
       changed_when: |
          'Installing' in slack_flatpak_install.stdout
-        failed_when: slack_flatpak_install.rc|int > 0 and 'already installed' not in slack_flatpak_install.stderr
+      failed_when: >-
+        slack_flatpak_install.rc|int > 0 and
+        'already installed' not in slack_flatpak_install.stderr

vscode.yml

 ---
 - hosts: all
-  become: yes
+  become: true
   become_user: root
   tasks:
     - name: Assertions
@@ -16,14 +16,15 @@
 
     - name: Add repo
       apt_repository:
+        # yamllint disable-line rule:line-length
         repo: deb [arch=amd64] http://packages.microsoft.com/repos/vscode stable main
         state: present
-        update_cache: True
+        update_cache: true
 
     - name: APT install
       apt:
         name: code
         state: present
-        install_recommends: False
-        update_cache: True
+        install_recommends: false
+        update_cache: true
         cache_valid_time: 3600

workstation.yml

@@ -2,14 +2,16 @@
 - include: desktop.yml
 - include: pkgs.yml
 - hosts: all
-  become: yes
+  become: true
   become_user: root
   vars:
-      docker_graph_directory: '/home/{{ ansible_env.SUDO_USER }}/.bind_mounts/docker'
+    docker_graph_directory: |-
+      /home/{{ ansible_env.SUDO_USER }}/.bind_mounts/docker
+
   handlers:
     - name: Systemd daemon reload
       systemd:
-        daemon_reload: yes
+        daemon_reload: true
 
     - name: Restart Docker
       service:
@@ -38,7 +40,7 @@
       apt:
         name: '{{ item }}'
         state: present
-      update_cache: yes
+        update_cache: true
         cache_valid_time: 3600
 
     - name: Set NetworkManager to ignore some interfaces
@@ -46,7 +48,12 @@
         dest: /etc/NetworkManager/NetworkManager.conf
         section: keyfile
         option: unmanaged-devices
-      value: interface-name:docker*;interface-name:vboxnet*;interface-name:nspawnbr*;interface-name:lxcbr0;interface-name:veth*
+        value: >-
+          interface-name:docker*;
+          interface-name:vboxnet*;
+          interface-name:nspawnbr*;
+          interface-name:lxcbr0;
+          interface-name:veth*;
         state: present
 
     - name: Allow local bridges access through the firewall
@@ -64,7 +71,7 @@
       user:
         name: '{{ ansible_env.SUDO_USER }}'
         groups: docker
-        append: True
+        append: true
         state: present
 
     - name: Create Docker graph directory
@@ -99,7 +106,7 @@
     - name: Get Docker graph directory mountpoint
       command: df {{ docker_graph_directory }}
       register: docker_graph_df
-    changed_when: False
+      changed_when: false
 
     - name: Create Systemd configuration override directories
       with_items:
@@ -133,16 +140,17 @@
         - Systemd daemon reload
 
     - name: Install Vagrant plugins
-    become: False
+      become: false
       with_items:
         - landrush
         - vagrant-vbguest
         - vagrant-gatling-rsync
       command: 'vagrant plugin install {{ item }}'
-    changed_when: False
+      changed_when: false
 
     - name: Get Leiningen
       get_url:
+        # yamllint disable-line rule:line-length
         url: https://raw.githubusercontent.com/technomancy/leiningen/stable/bin/lein
         dest: /usr/local/bin/lein
         owner: root
@@ -150,13 +158,14 @@
         mode: 0o0755
 
     - name: Install Leiningen
-    become: False
+      become: false
       command: lein
       register: install_leiningen
       changed_when: "'Downloading Leiningen' in install_leiningen.stdout"
 
     - name: Download Packer zip
       get_url:
+        # yamllint disable-line rule:line-length
         url: https://releases.hashicorp.com/packer/1.0.2/packer_1.0.2_linux_amd64.zip
         dest: /root/packer.zip
         owner: root
@@ -167,6 +176,6 @@
       unarchive:
         src: /root/packer.zip
         dest: /usr/local/bin/
-        remote_src: True
+        remote_src: true
         owner: root
         group: root