From da84d5c42a81b0122401f38a525916461ddc6597 Mon Sep 17 00:00:00 2001 From: Kieran Trezona-le Comte Date: Fri, 17 Jul 2015 10:30:04 +1200 Subject: [PATCH] Better names --- lib/sqlint/linter.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/sqlint/linter.rb b/lib/sqlint/linter.rb index 8ae1cd3..87f254f 100644 --- a/lib/sqlint/linter.rb +++ b/lib/sqlint/linter.rb @@ -15,7 +15,7 @@ module SQLint [].tap do |results| state = ParseState.new(@input, 0) while state != END_PARSE - error, new_parse_state = foo(state) + error, new_parse_state = parse_next_error(state) results << error if error state = new_parse_state end @@ -24,13 +24,13 @@ module SQLint private - def foo(parse_state) + def parse_next_error(parse_state) begin PgQuery.parse(parse_state.input) [nil, END_PARSE] rescue PgQuery::ParseError => e offset = e.location + parse_state.offset - line_number, column_number = find_position(offset) + line_number, column_number = find_absolute_position(offset) lint = Lint.new(@filename, line_number, column_number, :error, e.message) input_from_error = parse_state.input[e.location..-1] @@ -48,7 +48,7 @@ module SQLint end end - def find_position(offset) + def find_absolute_position(offset) lines_before_error = @input[0...(offset)].split("\n") line_number = lines_before_error.size column_number = lines_before_error.any? ? lines_before_error.last.size : 1 -- GitLab