From 8d2d3518813a69af80833e93438a03c324baf521 Mon Sep 17 00:00:00 2001
From: Adar Nimrod <nimrod@shore.co.il>
Date: Wed, 20 Mar 2019 19:35:03 +0200
Subject: [PATCH] Replace generated Bash completion scripts with ones that eval
 the output instead (instead of adding cleanup functionality to the
 gen-bash-completion script in case files linger in .bash_completion.d .

---
 .bash_completion.d/kops           |  1 +
 .bash_completion.d/kubectl        |  1 +
 .bash_completion.d/minikube       |  1 +
 .bash_completion.d/pandoc         |  1 +
 .bash_completion.d/pipenv         |  1 +
 .githooks/post-merge              |  2 --
 Documents/bin/gen-bash-completion | 13 -------------
 7 files changed, 5 insertions(+), 15 deletions(-)
 create mode 100644 .bash_completion.d/kops
 create mode 100644 .bash_completion.d/kubectl
 create mode 100644 .bash_completion.d/minikube
 create mode 100644 .bash_completion.d/pandoc
 create mode 100644 .bash_completion.d/pipenv
 delete mode 100755 Documents/bin/gen-bash-completion

diff --git a/.bash_completion.d/kops b/.bash_completion.d/kops
new file mode 100644
index 0000000..bf04536
--- /dev/null
+++ b/.bash_completion.d/kops
@@ -0,0 +1 @@
+command -v kops >/dev/null && eval $(kops completion bash)
diff --git a/.bash_completion.d/kubectl b/.bash_completion.d/kubectl
new file mode 100644
index 0000000..81269ab
--- /dev/null
+++ b/.bash_completion.d/kubectl
@@ -0,0 +1 @@
+command -v kubectl >/dev/null && eval $(kubectl completion bash)
diff --git a/.bash_completion.d/minikube b/.bash_completion.d/minikube
new file mode 100644
index 0000000..35f00a8
--- /dev/null
+++ b/.bash_completion.d/minikube
@@ -0,0 +1 @@
+command -v minikube >/dev/null && eval $(minikube completion bash)
diff --git a/.bash_completion.d/pandoc b/.bash_completion.d/pandoc
new file mode 100644
index 0000000..f62e7ba
--- /dev/null
+++ b/.bash_completion.d/pandoc
@@ -0,0 +1 @@
+command -v pandoc > /dev/null && pandoc --bash-completion > /dev/null && eval $( pandoc --bash-completion )
diff --git a/.bash_completion.d/pipenv b/.bash_completion.d/pipenv
new file mode 100644
index 0000000..17f1c10
--- /dev/null
+++ b/.bash_completion.d/pipenv
@@ -0,0 +1 @@
+command -v pipenv > /dev/null || eval $(pipenv --completion)
diff --git a/.githooks/post-merge b/.githooks/post-merge
index 520b681..7c12bf2 100755
--- a/.githooks/post-merge
+++ b/.githooks/post-merge
@@ -11,7 +11,5 @@ echo Loading dconf config >> /dev/stderr
 Documents/bin/dconf-load
 echo Configuring Git repo >> /dev/stderr
 git config --local status.showUntrackedFiles no
-echo Creating Bash completion scripts >> /dev/stderr
-Documents/bin/gen-bash-completion
 echo Adding Cron job >> /dev/stderr
 Documents/bin/cron-jobs
diff --git a/Documents/bin/gen-bash-completion b/Documents/bin/gen-bash-completion
deleted file mode 100755
index b7b21d0..0000000
--- a/Documents/bin/gen-bash-completion
+++ /dev/null
@@ -1,13 +0,0 @@
-#!/usr/bin/env bash
-set -eu
-
-gen_completion () {
-    executable="$1"
-    ! command -v "$executable" > /dev/null || "$@" > "$HOME/.bash_completion.d/$executable" || true
-}
-
-gen_completion pandoc --bash-completion
-gen_completion pipenv --completion
-gen_completion kops completion bash
-gen_completion kubectl completion bash
-gen_completion minikube completion bash
-- 
GitLab