From 2c76b41caf6c69a41545f110312f58b91a360204 Mon Sep 17 00:00:00 2001 From: Adar Nimrod <nimrod@shore.co.il> Date: Sun, 19 Sep 2021 19:17:08 +0300 Subject: [PATCH] Remove unsupported hooks. - Remove the Ansible Vault check hook, it did just the opposite. In case it's needed, use the one from https://git.shore.co.il/ansible/ansible-pre-commit, any tag before 0.8.0. - Remove the pip-outdated hook, it's a bad replacement for piprot (which is abandoned). If it's still needed use https://git.shore.co.il/nimrod/python-pre-commit. --- .pre-commit-hooks.yaml | 16 ---------------- README.md | 10 ---------- setup.py | 3 +-- 3 files changed, 1 insertion(+), 28 deletions(-) diff --git a/.pre-commit-hooks.yaml b/.pre-commit-hooks.yaml index 5e92aed..8deb7d4 100644 --- a/.pre-commit-hooks.yaml +++ b/.pre-commit-hooks.yaml @@ -15,14 +15,6 @@ types: [yaml] args: ['--inventory=localhost,', '--syntax-check'] -- id: ansible-vault-check - name: Verify vaulted files - description: Verify that Ansible Vault files are vaulted. - language: pygrep - files: vault - entry: |- - ANSIBLE_VAULT - - id: docker-compose name: docker-compose config description: Validate the Docker Compose file using docker-compose config @@ -60,11 +52,3 @@ entry: ./hooks/branch-merge-conflicts pass_filenames: false always_run: true - -- id: pip-outdated - name: pip-outdated - description: Find outdated Python dependencies in your requirements files. - language: python - entry: pip-outdated - args: ['--verbose'] - files: 'requirements.*\.txt$' diff --git a/README.md b/README.md index a4e65eb..0cf0a2e 100644 --- a/README.md +++ b/README.md @@ -19,13 +19,11 @@ A collection of [pre-commit](https://pre-commit.com/) hooks. hooks: - id: shell-validate - id: ansible-syntax-check - - id: ansible-vault-check - id: docker-compose - id: terraform-fmt - id: terraform-validate - id: poetry-check - id: branch-merge-conflict - - id: pip-outdated ``` ## Available hooks @@ -38,10 +36,6 @@ Check shell scripts with `/bin/sh -en`. Check Ansible playbooks for syntax errors. -### `ansible-vault-check` - -Verify that Ansible Vault files are vaulted. - ### `docker-compose` Validate the Docker Compose file using docker-compose config. @@ -64,10 +58,6 @@ Validate `pyproject.toml` files using Poetry. Checks for merge conflicts with a specific branch. -### `pip-outdated` - -Find outdated Python dependencies in your requirements files. - ## License This software is licensed under the MIT license (see `LICENSE.txt`). diff --git a/setup.py b/setup.py index c8959d7..1b48a0a 100644 --- a/setup.py +++ b/setup.py @@ -12,7 +12,6 @@ setup( install_requires=[ "ansible>=4", "docker-compose>=1.20", - "pip-outdated", "poetry", ], entry_points={ @@ -20,7 +19,7 @@ setup( "docker-compose-validate=hooks.docker_compose_validate:main", "terraform-validate=hooks.terraform_validate:main", "terraform-fmt=hooks.terraform_fmt:main", - "poetry-check=hook.poetry_check:main", + "poetry-check=hooks.poetry_check:main", ] }, packages=find_packages(), -- GitLab