Commit 2d52f714 authored by nimrod's avatar nimrod
Browse files

Integrate dockerfile_lint to my Docker image. 

- Include the npm package and sample rules in the image.
- Add a script to lint all files passed (otherwise just the first is
checked).
parent 9276abde

.dockerignore

+1 −0
Changes for .dockerignore: 1 added line, 0 removed lines.
Original line number Diff line number Diff line 
*

!docker-compose-config

!dockerfile-lint

.pre-commit-hooks.yaml

+1 −3
Changes for .pre-commit-hooks.yaml: 1 added line, 3 removed lines.
Original line number Diff line number Diff line
@@ -12,10 +12,8 @@ 
  description: A rule based 'linter' for Dockerfiles

  minimum_pre_commit_version: '0.18.0'

  language: docker_image

  entry: projectatomic/dockerfile-lint dockerfile_lint

  args: [ '-f' ]

  entry: adarnimrod/docker-pre-commit dockerfile-lint

  types: [ dockerfile ]

  require_serial: true

- id: docker-compose

  name: docker-compose config

  description: Validate the Docker Compose file using docker-compose config

Dockerfile

+16 −3
Changes for Dockerfile: 16 added lines, 3 removed lines.
Original line number Diff line number Diff line 
FROM alpine:3.10

RUN apk add --update --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ docker-compose && \

RUN apk add --update --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ \

        docker-compose \

        npm \

    && \

    docker-compose --version && \

    wget https://github.com/projectatomic/dockerfile_lint/archive/v0.3.3.tar.gz -O /tmp/dockerfile_lint.tar.gz && \

    npm install --global /tmp/dockerfile_lint.tar.gz && \

    install -d -o root -g root -m 755 /sample_rules && \

    tar -xzf /tmp/dockerfile_lint.tar.gz -C /tmp/ && \

    cp /tmp/dockerfile_lint*/sample_rules/*.yaml /sample_rules/ && \

    rm -rf /tmp/dockerfile_lint* && \

    dockerfile_lint --help && \

    wget https://github.com/hadolint/hadolint/releases/download/v1.17.1/hadolint-Linux-x86_64 -O /usr/local/bin/hadolint && \

    chmod +x /usr/local/bin/hadolint

COPY docker-compose-config /usr/local/bin/
 
    chmod +x /usr/local/bin/hadolint && \

    hadolint --version

COPY docker-compose-config dockerfile-lint /usr/local/bin/

USER nobody

dockerfile-lint

0 → 100755
+4 −0
Changes for dockerfile-lint: 4 added lines, 0 removed lines.
Original line number Diff line number Diff line 
#!/bin/sh

set -eu



echo "$@" | xargs -rtn1 dockerfile_lint --dockerfile