diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 83a18d25e58ca7adc2e526f0ed30b12263cb0c13..233bc80d8f4b0a2ed98f97e33a6269dd6ef0d882 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -8,7 +8,7 @@ - id: check-merge-conflict - id: flake8 - id: check-symlinks -- repo: https://www.shore.co.il/git/ansible-pre-commit +- repo: https://github.com/adarnimrod/ansible-pre-commit.git sha: 0fadd691465b97db8992cfc66650f630e433324b hooks: - id: ansible-syntax-check diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000000000000000000000000000000000000..abc583a44f62a169059b177cabed55bfe3ab9183 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,24 @@ +--- +language: python +python: "2.7" +dist: trusty +sudo: false +group: beta +services: [docker] +cache: + - pip + - directories: + - $HOME/.pre-commit + +install: + - pip install -r tests/requirements.txt | cat + - ansible-galaxy install git+file://$(pwd),$(git rev-parse --abbrev-ref HEAD) -p .molecule/roles + - molecule dependency + +script: + - pre-commit run --all-files + - molecule test --driver docker + +notifications: + webhooks: https://galaxy.ansible.com/api/v1/notifications/ + email: false diff --git a/README.rst b/README.rst index 644a627d3cb74fd6c00383055de273a466cdb20a..5468d6a4fb2dd1f6275d4e62b6395c4424b2bba8 100644 --- a/README.rst +++ b/README.rst @@ -1,13 +1,15 @@ Networkd ######## +.. image:: https://travis-ci.org/adarnimrod/networkd.svg?branch=master + :target: https://travis-ci.org/adarnimrod/networkd + Provision Systemd-networkd. Requirements ------------ -See :code:`meta/main.yml`, :code:`tests/requirements.yml` and assertions at -the top of :code:`tasks/main.yml`. +See :code:`meta/main.yml` and assertions at the top of :code:`tasks/main.yml`. Role Variables -------------- @@ -27,21 +29,22 @@ See :code:`tests/playbook.yml`. Testing ------- -Testing requires Virtualbox and Vagrant and Python 2.7. Install the Python -dependencies, add pre-commit hooks by running: +Testing requires Python 2.7 and either Docker or Vagrant and Virtualbox. +Install the Python dependencies, dependent roles and roles required for +testing: .. code:: shell pip install -r tests/requirements.txt - pre-commit install + ansible-galaxy install git+file://$(pwd),$(git rev-parse --abbrev-ref HEAD) -p .molecule/roles + molecule dependency To run the full test suite: .. code:: shell - ansible-galaxy install git+file://$(pwd),$(git rev-parse --abbrev-ref HEAD) -p .molecule/roles - molecule test --platform all pre-commit run --all-files + molecule test --platform all License ------- diff --git a/ansible.cfg b/ansible.cfg index 2bc7613f4df5ddc0fe0f2719df832ddfff4bfe62..a33a906b7db5fa209df2b129eff0b36c42f661d9 100644 --- a/ansible.cfg +++ b/ansible.cfg @@ -2,9 +2,10 @@ library = library host_key_checking = False retry_files_enabled = False -roles_path = .molecule/roles:.molecule/../roles:../:../../ +roles_path = ../:.molecule/roles:.molecule/../roles:../../ command_warnings = True deprecation_warnings = True +callback_whitelist = profile_tasks [ssh_connection] pipelining = True diff --git a/defaults/main.yml b/defaults/main.yml index c5a53e47ddcb64ccf2a8142a9e68b7acc2c5b69c..adbaa4aede1fb141a1e6d08a7eb546d3ee2d526f 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -1,2 +1,2 @@ --- -# defaults file for ansible-role-networkd +# defaults file for networkd diff --git a/handlers/main.yml b/handlers/main.yml index 4d11a232c0f860711df99da5f3c05d8be22305a6..0cc8acf0a50042b74b6aac5a092d3a315644d981 100644 --- a/handlers/main.yml +++ b/handlers/main.yml @@ -1,5 +1,6 @@ --- -# handlers file for ansible-role-networkd +# handlers file for networkd + - name: Restart Systemd-networkd service: name: systemd-networkd diff --git a/molecule.yml b/molecule.yml index 036b153d19386b3d72b8330b35061e77a8f81f63..97242039f28ba7dae2ee912b427f72d6f556ebad 100644 --- a/molecule.yml +++ b/molecule.yml @@ -5,15 +5,21 @@ ansible: diff: True config_file: ../ansible.cfg +dependency: + name: galaxy + requirements_file: tests/requirements.yml + vagrant: providers: - name: virtualbox type: virtualbox platforms: - - name: debian + - name: jessie box: debian/jessie64 + - name: xenial + box: ubuntu/xenial64 instances: - - name: ansible-role-networkd + - name: networkd options: append_platform_to_hostname: yes raw_config_args: @@ -21,3 +27,17 @@ vagrant: - 'vbguest.auto_update = false' - 'landrush.enabled = false' - 'landrush_ip.override = false' + +docker: + containers: + - name: networkd-xenial + image: ubuntu + image_version: xenial + command: /sbin/init + privileged: True + volume_mounts: + - /sys/fs/cgroup:/sys/fs/cgroup + - /var/run/dbus/system_bus_socket:/var/run/dbus/system_bus_socket + environment: + DEBIAN_FRONTEND: noninteractive + container: docker diff --git a/tasks/main.yml b/tasks/main.yml index b09fa15ca292abc95ff0e8b5cc3cbe48cc96bfe9..c828fbdcad0c24561d7472d2e4e98b20a46c430c 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -1,5 +1,6 @@ --- -# tasks file for ansible-role-networkd +# tasks file for networkd + - name: Assertions assert: that: diff --git a/tests/playbook.yml b/tests/playbook.yml index a4cb8ac9ba506f9b2250dad25b63f05087a5cf47..f58a89485cedefe18e781b2141d6ce9e56730ebf 100644 --- a/tests/playbook.yml +++ b/tests/playbook.yml @@ -1,4 +1,9 @@ --- +- hosts: networkd-xenial + gather_facts: false + roles: [debian-bootstrap] + - hosts: all + strategy: free roles: - - role: ansible-role-networkd + - role: networkd diff --git a/tests/requirements.txt b/tests/requirements.txt index 0588c359a06c17f6d8a27f8d19be6cf89b2758b8..e48b249b4899c9d8170a65953599aa44c633517f 100644 --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -1,6 +1,11 @@ ansible==2.2.0.0 -testinfra==1.4.3 -molecule==1.13.0 -ansible-lint==3.4.4 -pre-commit==0.9.3 +testinfra==1.4.5 +molecule==1.17.0 +ansible-lint==3.4.8 +pre-commit==0.9.4 piprot==0.9.7 +python-vagrant==0.5.14 +docker-py==1.10.6 +netaddr==0.7.18 +passlib==1.7.0 +bcrypt==3.1.2 diff --git a/tests/requirements.yml b/tests/requirements.yml index 8b9b2bcba3b4459621ff239243ac0375a081f20a..70716f60b9e624bc5a09442517a08667363949f4 100644 --- a/tests/requirements.yml +++ b/tests/requirements.yml @@ -1,7 +1,5 @@ --- -- src: https://www.shore.co.il/git/ansible-role-openbsd-bootstrap - scm: git - name: openbsd_bootstrap -- src: https://www.shore.co.il/git/ansible-role-debian-bootstrap - scm: git - name: debian_bootstrap +- src: adarnimrod.openbsd-bootstrap + name: openbsd-bootstrap +- src: adarnimrod.debian-bootstrap + name: debian-bootstrap diff --git a/tests/test_example.py b/tests/test_example.py index 12d4c7a5294fc8128e8ae695e8afaaa62a002f9b..aaea50030b9784f0528df9b936cf1903d3af5994 100644 --- a/tests/test_example.py +++ b/tests/test_example.py @@ -1,7 +1,12 @@ +from testinfra.utils.ansible_runner import AnsibleRunner + +testinfra_hosts = AnsibleRunner('.molecule/ansible_inventory').get_hosts('all') + + def test_example(Command): assert Command('uname').rc == 0 def test_root(Command, Sudo): with Sudo(): - assert Command('whoami').stdout == 'root' + assert Command('whoami').stdout.strip() == 'root' diff --git a/vars/main.yml b/vars/main.yml index 98094a9b5b024eeada7d8b426df8fae07e71b689..11e221322ce44ed567dfcc18d42a4075797277ae 100644 --- a/vars/main.yml +++ b/vars/main.yml @@ -1,2 +1,2 @@ --- -# vars file for ansible-role-networkd +# vars file for networkd